Upgrade to Laravel 11 - #368
Conversation
…ackpack/pro package as we will not purchase license for v2
… after uninstalling backpack/pro package
|
Seems like a decent plan. I disagree with Claude on a few points, particularly:
It might be technically deployable, but we'll have regressed in features by removing Backpack Pro; we won't have a publishable version until we get to the end of the process. Also, make sure you've considered how much time it's worth putting into doing upgrades to Backpack - 5 to 6 and 6 to 7 are non-trivial, we'd lose features that are Pro-only so we won't have feature parity anyway, and spending time fixing / fully testing the app on those newer versions is time lost because we're moving to Filament. If you're definitely going incrementally, then it might be worth not getting all the way to Laravel 13 before bringing in Filament; Filament 5 runs on a version of Laravel 11, so that's an option to consider, that skips the later Backpack requirements. |
|
Also - I just tried running the test suite locally, and got lots of fails. It looks like there's a significant bug in the tests since we moved to "teams" mode in the Spatie Permissions package - All class-based tests don't get the context of the 'current organisation', so when trying to do the setup functions like "setupSiteAdminUser()" etc, it tries to add "organisation_id=null" into the database, which fails due to the db-level constraints. So the test suite needs fixing before it's useful again. I would recommend also adding a github workflow to auto-run the tests on every PR or push to dev; like we do on other apps. |
Yes. There are many broken pages after removing Backpack Pro.
Yes. I think we do not need to upgrade Backpack from 6 to 7. It is good enough to upgrade Backpack from 5 to 6. Then start migrating pages from backpack to filament.
We have upgraded to Laravel 11 in this branch. Both backpack 6 and filament 5 can run on it. |
Yes, the test suite needs refinement. It takes a very long duration to run in my local env... |
Add Backpack Theme Coreuiv4
…gnore record that is already existed in database
…ed even email notification cannot be sent due to mailgun issue
Install Filament Package
This PR is submitted to upgrade Laravel from 10 to 11.
After checking with Claude, it is recommended to upgrade Laravel from 10 to 11, 11 to 12, 12 to 13 instead of upgrading from 10 to 13 directly.
It is not yet ready for review. It is submitted for progress update.
Claude's response:
Go incremental (10→11→12→13) — and it looks like you've already started down that path: your working composer.json diff shows laravel/framework bumped to ^11.0 and backpack/crud to ^6.0, with laravel/telescope also nudged for compatibility.
Why incremental is the right call here:
Main con of incremental: more total PRs/composer-update cycles and more time spent re-running the test suite at each stage — but given the Backpack dependency chain, that overhead buys real safety.
Con of direct 10→13: composer will likely just refuse to resolve in one shot (packages like Backpack won't have a single version spanning Laravel 10 through 13), and even if you forced it, you'd be debugging three majors' worth of breaking changes simultaneously with no incremental green checkpoint.
Given you're already on the incremental branch (upgrade-to-laravel-11), I'd just continue that pattern: land 11 cleanly, merge to dev, then branch for 12, then 13.