Add missing smoke and CRUD tests, fix two vacuous tests - #57
Closed
dave-mills wants to merge 2 commits into
Closed
Conversation
Implements docs/plans/MISSING_SMOKE_CRUD_TESTS.md: - Smoke: root path redirects to app login (adapted from removed cover page) - Admin CRUD: dataset name-required + edit, program record URL, xlsform module bulk delete - Admin CRUD fixes: delete duplicate vacuous module-version create test; rework wrong-table delete test into 'can delete xlsform module version' - App CRUD: farm bulk delete, choice list entry create/edit/delete - TestCase: declare shared $choiceList property Smoke + CRUD suites: 77 -> 85 tests, all passing. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements docs/plans/MISSING_SMOKE_CRUD_TESTS.md — the follow-up audit of the original smoke/CRUD test plans. Smoke + CRUD suites go from 77 to 85 tests, all passing.
New tests
Smoke — PublicRoutesTest
root path redirects to app login—/is now a redirect to/app(adapted from the obsolete "cover page loads" item).Admin CRUD
create dataset requires name,can edit datasetprogram list links to program panel— asserts the rendered list contains theprogram/{id}record URL from therecordUrloverridecan delete xlsform modulevia the groupedDeleteBulkAction(the table has no row delete and no create action)App CRUD
can bulk delete farm— builds the LocationLevel → Location → Farm chain manually (no Farm factory)Fixed vacuous tests (AdminPanelCrudTest, XlsformModuleVersion block)
can create xlsform module version— it asserted axlsform_modulesrow thebeforeEachhad already created.can delete xlsform moduleintocan delete xlsform module version— it previously asserted against the wrong table (xlsform_modules), so it passed without testing the delete.Other
tests/TestCase.php: declared shared$choiceListproperty (matches the existing$team/$xlsformTemplatepattern; keeps phpstan clean).HddsHintssmoke test — itsmount()404s without an HDDS module version linked to a deployed xlsform (noted in AppPanelTest).SMOKE_TESTS.md,CRUD_TESTS.md) marked Completed, with obsolete items listed; change log at docs/change-logs/missing-smoke-crud-tests.md.Verification
pest tests/Feature/Smoke tests/Feature/Crud: 85 passedphpstan: no new errors;pint: appliedTranslationImportTest/XlsformTemplateImportTest(broadcast to a local Reverb server on port 8080) — unrelated to this change.