Swap proc/view creation order and fix bugs in proc step - #9
Open
stevelacey wants to merge 2 commits into
Open
Conversation
The `processProcsDir` method should use the `$dir_path` passed to it and return the count. Also, it's likely that the views make use of the procs, so create the procs first so the view create can succeed.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
processProcsDirmethod should use the$dir_pathpassed to it and return the count.Also, it's likely that the views make use of the procs, so create the procs first so the view create can succeed.
Lastly, the procs method should recurse with its own method, not the view method.