-
Notifications
You must be signed in to change notification settings - Fork 32
EIP 7919: Pureth Meta #822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
RazorClient
wants to merge
13
commits into
status-im:master
Choose a base branch
from
RazorClient:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3eb2379
Add Pureth types and tests
RazorClient 2024322
RT Blocks
RazorClient 2755d18
reduce rt tests as Block rt not possible
RazorClient 5a0329b
add new ssz receipts helpers
RazorClient d4c79c1
Merge branch 'master' into Pureth
RazorClient 051ab14
Merge pull request #3 from RazorClient/Pureth
RazorClient e112489
Add new StoredReceipt variants
RazorClient 581184c
address reviews
RazorClient 7bfd271
upstream fixes
RazorClient 6972001
fix el errors
RazorClient 3ba8f69
add systemsLogRoot in header
RazorClient d4b3f28
Eip-6466 bumps
RazorClient 46e358c
Merge branch 'master' into master
RazorClient File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,3 +21,5 @@ nimble.paths | |
|
|
||
| #OS specific files | ||
| **/.DS_Store | ||
|
|
||
| .claude/ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| {.push raises: [].} | ||
|
|
||
| import | ||
| ../common/[addresses, hashes, base], | ||
| std/[typetraits], | ||
| ssz_serialization, | ||
| ssz_serialization/codec, | ||
| ssz_serialization/merkleization | ||
|
|
||
| # This follows how | ||
| # https://github.com/status-im/nimbus-eth2/blob/9839f140628ae0e2e8aa7eb055da5c4bb08171d0/beacon_chain/spec/ssz_codec.nim#L29 | ||
| # does it for addresses in eth 2 | ||
| export ssz_serialization, codec, base, typetraits | ||
|
|
||
| # SSZ for Address | ||
| template toSszType*(T: Address): auto = | ||
| distinctBase(T) | ||
|
|
||
| func fromSszBytes*(T: type Address, bytes: openArray[byte]): T {.raises: [SszError].} = | ||
| readSszValue(bytes, distinctBase(result)) | ||
|
|
||
| # SSZ for Hash32 | ||
| template toSszType*(T: Hash32): auto = | ||
| distinctBase(T) | ||
|
|
||
| func fromSszBytes*(T: type Hash32, bytes: openArray[byte]): T {.raises: [SszError].} = | ||
| readSszValue(bytes, distinctBase(result)) | ||
|
|
||
| # SSZ for Bytes32 | ||
| template toSszType*(T: Bytes32): auto = | ||
| distinctBase(T) | ||
|
|
||
| func fromSszBytes*(T: type Bytes32, bytes: openArray[byte]): T {.raises: [SszError].} = | ||
| readSszValue(bytes, distinctBase(result)) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is
txGasUsedrequired from spec?If yes please mentioned spec link in comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yups
Here's the above-mentioned Link
https://github.com/ethereum/EIPs/blob/676604927b316a44195008e632778d4ca1101deb/EIPS/eip-6466.md?plain=1#L138
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention it in the code as a comment