chore: relax nim-websock cap to allow v0.4.0#277
Open
chaitanyaprem wants to merge 1 commit into
Open
Conversation
PR status-im#269 raised the cap to `< 0.4.0` on Apr 11 2026 -- before nim-websock v0.4.0 was released (May 13 2026). The cap was a conservative pin from "latest websock at time of writing", not a known incompatibility. Verified locally: with `websock == 0.4.0` forced, all 196 nim-json-rpc tests pass on both refc and orc backends. nim-websock v0.4.0's API changes (PR status-im#194 "make rng agnostic") add an `rng` parameter to `WebSocket.connect()` with a default value, so existing call sites in clients/websocketclient.nim still compile. The internal `accept` refactor (acceptStream extraction) preserves the public proc signature used by servers/websocketserver.nim. This unblocks downstream consumers (e.g. waku via nim-libp2p v2.0.0) that require `websock >= 0.4.0`.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #269 raised the cap to
< 0.4.0on Apr 11 2026 -- beforenim-websock v0.4.0 was released (May 13 2026). The cap was a
conservative pin from "latest websock at time of writing", not a
known incompatibility.
Verified locally: with
websock == 0.4.0forced, all 196 nim-json-rpctests pass on both refc and orc backends. nim-websock v0.4.0's API
changes (PR #194 "make rng agnostic") add an
rngparameter toWebSocket.connect()with a default value, so existing call sitesin clients/websocketclient.nim still compile. The internal
acceptrefactor (acceptStream extraction) preserves the public proc
signature used by servers/websocketserver.nim.
This unblocks downstream consumers (e.g. waku via nim-libp2p v2.0.0)
that require
websock >= 0.4.0.