Skip to content

Fixing android unattach bug #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emmyrlim wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixing android unattach bug #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a5f925
Fixing android unattach bug
emmyrlim Jan 14, 2024
a2f78f5
remove sInstances
emmyrlim Jan 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions android/src/main/java/com/transparentvideo/AlphaMovieView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,12 +427,9 @@ public void onPause() {
pause();
}

@Override
protected void onDetachedFromWindow() {
super.onDetachedFromWindow();
protected void cleanup() {
release();
handler.removeCallbacks(timeDetector);
TransparentVideoViewManager.destroyView((LinearLayout)this.getParent());
handler.removeCallbacks(timeDetector);
}

private void prepareAsync(final MediaPlayer.OnPreparedListener onPreparedListener) {
Expand Down
10 changes: 5 additions & 5 deletions android/src/main/java/com/transparentvideo/TransparentVideoViewManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@

public class TransparentVideoViewManager extends SimpleViewManager<LinearLayout> {

private static List<LinearLayout> sInstances = new ArrayList<>();

public static final String REACT_CLASS = "TransparentVideoView";
private static final String TAG = "TransparentVideoViewManager";

Expand All @@ -43,12 +41,14 @@ public String getName() {
@NonNull
public LinearLayout createViewInstance(ThemedReactContext reactContext) {
LinearLayout view = new LinearLayout(this.reactContext);
sInstances.add(view);
return view;
}

public static void destroyView(LinearLayout view) {
sInstances.remove(view);
@Override
public void onDropViewInstance(@NonNull LinearLayout view) {
super.onDropViewInstance(view);
AlphaMovieView alphaMovieView = (AlphaMovieView)view.getChildAt(0);
alphaMovieView.cleanup();
}

@ReactProp(name = "src")
Expand Down