fix(prover): allow base_fee = 0 for gasless chains#190
Open
nadeemb53 wants to merge 1 commit into
Open
Conversation
nadeemb53
force-pushed
the
fix/prover-gasless-base-fee
branch
3 times, most recently
from
18ef4f4 to
cf938e8
Compare
nadeemb53
force-pushed
the
fix/prover-gasless-base-fee
branch
from
cf938e8 to
e3e254f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swap
validate:"required"onConfig.Layer2.BaseFeefor an explicitviper.IsSet("layer2.base_fee")check.requiredrejects 0 on a uint, blocking gasless L2 setups where every block hasbaseFeePerGas=0. Missing-field detection for non-gasless chains is preserved and the error format is unchanged.Zero is ZK-safe: the execution circuit gates the baseFee public-input check with
mustBeEqualIfExtractedIsNonZeroinprover/circuits/execution/pi_wizard_extraction.go, so the constraint is trivially satisfied when the extracted block baseFee is 0.