Review follow-ups: tests + docs (ASH-216..219)#14
Merged
Conversation
The "Switch criteria" checklist had lost items 1-3 and 5-6 in a past edit, leaving a list that started at 4 and skipped 5-6 — and grep/find, the two most-used verbs, had no entry at all. Collapsed to a contiguous 1-10 list and restored first-class entries for `ash grep` (1) and `ash find` (2). The remaining eight items keep their text, renumbered 3-10. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
These three packages had no *_test.go files — the suite counted them as passing only vacuously, despite atomicwrite (the durability guarantee behind ash write/edit) and runner (every shelled subprocess) being correctness-critical. - runner: binary-not-found, success, non-zero exit (not an error), stderr capture, MaxStdout truncation incl. the exact-at-cap boundary. - atomicwrite: create, replace, no leftover temp file, PreserveMode, the 0600-reset when PreserveMode is off, error on missing parent. - session: Root marker discovery + no-marker fallback, SocketPath stability/scoping, the project path helpers, EnsureRuntimeDirs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
docs/ had ~40 files across six subdirectories with no map — a newcomer could not tell reference docs from measurement logs or speculative notes. - docs/README.md — a categorized index (getting started / reference / design notes / measurements / generated artifacts / historical). - docs/value-assessment/README.md — marks the directory a point-in-time May 2026 snapshot, not living documentation. - docs/revolutionary-directions.md — a "speculative, not a roadmap" banner so a stranger does not read it as committed work. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Found in the post-public-release docs review. The README's product summary lagged the shipped surface by ~one phase of work. - §The verb surface: added the 8 verbs it omitted — `build`, `lang` (new Semantic section), `recap`, `workspace`, `replay`, `usage`, `turn`, and `git --op blame`. The surface now matches `ash help`. - `lang` was described as "the forthcoming lang verb ... via tree-sitter" — it shipped, it is LSP-backed not tree-sitter, and it is in a usage-validation freeze. Corrected design principle 8 and reframed roadmap Phase 3 as shipped-under-evaluation. - §Architecture diagram showed a "registered tools (cargo, npm, pytest)" box as a live component — tool registration is Phase 5. Relabelled it "tool registry (Phase 5 — not yet shipped)". - Dropped the internal "ship 14" cadence jargon from the public verb-surface intro and the Phase 2 roadmap header. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four docs/tests follow-ups from the post-public-release review. One commit per ticket; no behavior change.
runner,atomicwrite,session, which had no*_test.gofiles despite being correctness-critical. Covers runner exit-code/truncation handling, atomicwrite atomicity + mode behavior, session path resolution.langreframed as shipped/LSP-backed/frozen, architecture diagram's non-existent "registered tools" box relabelled as Phase 5, "ship 14" jargon dropped.docs/README.mdindex, plus framing for the historicalvalue-assessment/snapshot and the speculativerevolutionary-directions.md.grep/findentries restored.🤖 Generated with Claude Code