Skip to content

wrong option checked for admin bcc#441

Open
jnorell wants to merge 1 commit into
stcr:masterfrom
jnorell:patch-2
Open

wrong option checked for admin bcc#441
jnorell wants to merge 1 commit into
stcr:masterfrom
jnorell:patch-2

Conversation

@jnorell

@jnorell jnorell commented Sep 14, 2018

Copy link
Copy Markdown
Contributor

The admin should be bcc'd according to the admin_bcc option, not notify_authors.

The admin should be bcc'd according to the admin_bcc option, not notify_authors.
@jnorell

jnorell commented Sep 14, 2018

Copy link
Copy Markdown
Contributor Author

hmm.. I subsequently see the admin_bcc being handled via a Bcc: header in utils/stcr_utils.php (send_mail()) - so maybe I misunderstood what line 237-238 is doing. But, it certainly seems like a bug there.

What is actually happening is a check for the 'Subscribe authors' setting (Automatically subscribe authors to their own articles) -- and if that setting is enabled, it sends the site admin (not the post author) an email at that point. How I would expect that setting to be handled is simply to add a subscription for a post author when a post is published. If the intended implementation of that feature is to automatically notify post authors instead, then maybe what's appropriate is to change the setting name/description to reflect that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant