Skip to content

fix: restore Linux and release checks - #2

Merged
wiiiimm (wiiiimm) merged 1 commit into
mainfrom
fix/ci-failures
Sep 10, 2026
Merged

fix: restore Linux and release checks#2
wiiiimm (wiiiimm) merged 1 commit into
mainfrom
fix/ci-failures

Conversation

@wiiiimm

Copy link
Copy Markdown
Member

Summary

  • gate macOS-only Rust imports and filter protocol types so strict Linux Clippy succeeds
  • give both Cargo workspace members concrete versions so Release Please can update them
  • remove the now-unused inherited workspace version

Failed runs addressed

Validation

  • cargo fmt --all -- --check
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace
  • cargo build --release --workspace --locked

Linear: https://linear.app/stealth-company/issue/SWR-473/complete-the-cross-platform-rust-core-and-tui-migration

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Team

Run ID: fb3fc4a2-13a7-4eb0-9025-b4d49976d74e

📥 Commits

Reviewing files that changed from the base of the PR and between 6d13750 and 5db08c8.

📒 Files selected for processing (5)
  • Cargo.toml
  • rust/traffic-ctrl-core/Cargo.toml
  • rust/traffic-ctrl/Cargo.toml
  • rust/traffic-ctrl/src/filter.rs
  • rust/traffic-ctrl/src/inspector.rs
💤 Files with no reviewable changes (1)
  • Cargo.toml

Included review availability: 7 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (1)
  • GitHub Check: Greptile Review
🔇 Additional comments (4)
rust/traffic-ctrl/src/filter.rs (1)

8-8: LGTM!

Also applies to: 136-136, 146-146, 156-156

rust/traffic-ctrl/src/inspector.rs (1)

1-1: LGTM!

Also applies to: 9-10

rust/traffic-ctrl-core/Cargo.toml (1)

3-3: LGTM!

rust/traffic-ctrl/Cargo.toml (1)

3-3: LGTM!


Summary by CodeRabbit

  • Compatibility

    • Improved cross-platform build compatibility by limiting macOS-specific filtering components to macOS builds.
    • Maintained shared collection support across platforms without changing runtime behaviour.
  • Maintenance

    • Clarified package version handling by assigning explicit crate versions while retaining workspace metadata.
    • No changes to public APIs or end-user functionality.

Walkthrough

The workspace version is removed, and both crates declare version 0.0.0. macOS-only filter declarations and HashSet imports are excluded from non-macOS builds.

Changes

Package version metadata

Layer / File(s) Summary
Explicit crate versions
Cargo.toml, rust/traffic-ctrl-core/Cargo.toml, rust/traffic-ctrl/Cargo.toml
The workspace no longer declares a package version. Both crates declare version 0.0.0 directly.

macOS-specific compilation

Layer / File(s) Summary
macOS filter declarations
rust/traffic-ctrl/src/filter.rs
The filter protocol import and filter declarations now compile only on macOS.
macOS inspector imports
rust/traffic-ctrl/src/inspector.rs
HashSet is imported only on macOS. HashMap remains available on all platforms.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 5db08

This change restores Linux build checks by limiting macOS-only declarations to macOS and makes both Rust crates explicitly versioned for release automation. No remaining merge-readiness risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarises the main changes: restoring Linux CI checks and release checks.
Description check ✅ Passed The description directly explains the macOS gating changes, Cargo version changes, failed runs, and validation steps.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ci-failures
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/ci-failures

A rabbit reads each line,
The patch grows clear beneath the moon,
Small changes hop in place,
Tests guard the garden path,
Reviews bloom before the dawn.

Comment @coderabbitai help to get the list of available commands.

@wiiiimm
wiiiimm (wiiiimm) marked this pull request as ready for review September 10, 2026 08:51
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-10T08:55:49.788326Z 5db08c8 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@greptile-apps

greptile-apps Bot commented Sep 10, 2026

Copy link
Copy Markdown

RetriggerConfidence Score: 5/5

The PR appears safe to merge, with the platform gates matching all affected references and the release metadata remaining internally consistent.

Summary

  • Moving package versions from inherited workspace metadata into both concrete crate manifests.
  • Gating macOS-only filter protocol types and imports on macOS.
  • Gating the macOS-only HashSet import in the inspector.

Reviews (1) · Last reviewed commit: "fix: restore Linux and release checks"

@wiiiimm
wiiiimm (wiiiimm) merged commit a8bd575 into main Sep 10, 2026
9 checks passed
@wiiiimm
wiiiimm (wiiiimm) deleted the fix/ci-failures branch September 10, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant