Skip to content

Add Trip Editor error-state contract coverage#300

Merged
stef-k merged 2 commits into
mainfrom
fix/trip-editor-error-state-contracts-297-batch3
May 18, 2026
Merged

Add Trip Editor error-state contract coverage#300
stef-k merged 2 commits into
mainfrom
fix/trip-editor-error-state-contracts-297-batch3

Conversation

@stef-k
Copy link
Copy Markdown
Owner

@stef-k stef-k commented May 18, 2026

Summary

Implements #297 Batch 3 only: Trip Editor stale/error/dirty/delete feedback contracts.

  • Adds focused mocked Playwright coverage for failure feedback and state preservation.
  • Failed place save keeps the active draft and leaves persisted row/API state unchanged.
  • Failed segment save covers the separate SegmentManager feedback path and keeps draft values.
  • Delete confirmation gates mutation; canceled confirmation sends no request.
  • Failed delete keeps the editor/row visible and shows danger feedback.
  • Clean cancel and dirty keep/discard paths behave deterministically.

Claim Boundary

These tests intentionally use mocked non-2xx mutation responses for hard-to-trigger browser failure states. They prove frontend failure feedback and state preservation only. They do not claim CRUD persistence proof.

Batch 2 real endpoint specs cover successful delete/removal/persistence. This PR does not duplicate that success proof.

Out Of Scope

Validation

  • Focused new spec: 4 passed.
  • Playwright list: passed, 114 tests listed.
  • dotnet build: passed.
  • dotnet test: passed, 1537 tests.
  • LOC check: passed; no new Batch 3 warning.
  • git diff --check origin/main...HEAD: passed.
  • tracked artifact scan: clean.

@stef-k stef-k merged commit 4290dc2 into main May 18, 2026
1 check passed
@stef-k stef-k deleted the fix/trip-editor-error-state-contracts-297-batch3 branch May 18, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant