Add Trip Editor asset-mode smoke checks#303
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #297 Batch 6 only: explicit opt-in Trip Editor asset-mode smokes.
tools/trip-editor-asset-smoke.mjs.npm run smoke:trip-editor:assets:devnpm run smoke:trip-editor:assets:publishednpm run smoke:trip-editor:assetsdocs/22-Testing.md..gitignorecoverage for smoke output directories.Asset Claims
The Development smoke verifies ASP.NET Development + Vite dev-server asset wiring.
The published smoke builds and publishes the app, launches that published output on an allocated local URL by default, and verifies production assets are served without Vite dev-server requests.
These smokes prove asset loading and published-output serving only. They do not prove Trip Editor CRUD persistence or editor workflow behavior; those are covered by the dedicated #297 CRUD, error-state, search-add, and rich-notes contract batches.
Published Smoke Guardrails
127.0.0.1port by default.WAYFARER_ASSET_SMOKE_PUBLISHED_URLif it already responds before launch.Validation
npm run smoke:trip-editor:assets:published: passed.npm run smoke:trip-editor:assets:dev: passed.npx playwright test --config=playwright.config.ts --list: passed, 117 tests listed.dotnet build: passed.dotnet test: passed, 1547 tests.git diff --check origin/main...HEAD: passed.Full Trip Editor E2E remains intentionally deferred for the final #297 validation pass after this batch merges.