Skip to content

Stabilize final Trip Editor E2E validation#304

Merged
stef-k merged 2 commits into
mainfrom
fix/trip-editor-e2e-final-determinism-297
May 18, 2026
Merged

Stabilize final Trip Editor E2E validation#304
stef-k merged 2 commits into
mainfrom
fix/trip-editor-e2e-final-determinism-297

Conversation

@stef-k
Copy link
Copy Markdown
Owner

@stef-k stef-k commented May 18, 2026

#297 final determinism stabilization

Fixes the final full-suite Trip Editor E2E determinism failures after Batches 1-6.

Changes:

  • Stabilized copy-link feedback assertions without racing the 1800ms reset lifecycle.
  • Fixed inline segment editor row layout so active segment editors do not overlap following row controls.
  • Made sidebar search fixtures prefer an editable normal region/place pair while preserving Unassigned Places coverage in dedicated tests.
  • Scoped visual-polish Expand clicks to the docked editor and scrolls them into view before clicking.
  • Prevented real CRUD cleanup from retrying segment IDs already deleted by the test.
  • Scoped rich-notes time budgets for full-suite load and tightened image assertions around inserted/data-image contracts.

Validation

  • Original failing tests passed focused/repeated.
  • Failing specs together passed: 18 passed.
  • Full npm run test:e2e:trip-editor passed: 117 passed, 32.9m.
  • npx playwright test --config=playwright.config.ts --list passed: 117 tests.
  • dotnet build passed.
  • dotnet test passed.
  • npm run build passed.
  • npm run smoke:trip-editor:assets:dev passed.
  • npm run smoke:trip-editor:assets:published passed.
  • LOC check passed; tripEditorRichNotes.spec.ts is exactly 600 LOC and accepted as cohesive existing rich-notes parity coverage at the cap.
  • git diff --check and artifact hygiene were clean.

Claim Boundary

This does not add new product scope, does not weaken #297 proof boundaries, does not convert real endpoint tests back to mocked tests, and does not add skips.

@stef-k stef-k merged commit 02c59c2 into main May 18, 2026
1 check passed
@stef-k stef-k deleted the fix/trip-editor-e2e-final-determinism-297 branch May 18, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant