Fix reset-password CLI scope#307
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reset-passwordCLI command after the password reset instead of continuing into web startup.builder.Services.BuildServiceProvider()in the CLI path with a minimal command host and scopedUserManager<ApplicationUser>resolution.Validation
dotnet build: passed, 0 warnings / 0 errors; ASP0000 is gone.dotnet run -- reset-password: printed usage and exited without starting the web app.dotnet run -- reset-password user2 User2!: reset succeeded and printed the success message.user2/User2!: passed.dotnet test: passed, 1547/1547.dotnet run --project tools/Wayfarer.LocCheck -- --warn 400 --fail 600: passed with existing warnings only.git diff --check: passed, normal CRLF working-copy warning only.Notes
No normal web startup service registration was changed; the patch is scoped to the admin CLI reset-password path.