Skip to content

Polish Trip Editor visit progress modal#311

Merged
stef-k merged 2 commits into
mainfrom
fix/trip-editor-visit-progress-polish-309
May 19, 2026
Merged

Polish Trip Editor visit progress modal#311
stef-k merged 2 commits into
mainfrom
fix/trip-editor-visit-progress-polish-309

Conversation

@stef-k
Copy link
Copy Markdown
Owner

@stef-k stef-k commented May 19, 2026

Summary

Closes #309.

Design changes summary

  • Polishes the Trip Editor Visit progress and history modal with a stronger overall progress summary, percent badge, intentional progress bars, segmented filter controls, status affordances, compact visit-count pills, per-region progress counts, and denser visit detail rows.
  • Keeps the styling scoped to the existing Vue Trip Editor visit-progress surface and focused visitProgress.css file.

Preserved from the Vue editor

  • Preserves the expanded modal shell, header, backdrop, scroll containment, Read-only visits context, current filtering state, and existing editor DTO/state model.
  • Preserves owner/editor data richness: first visit, last visit, full visit history rows, and the Manage visit action.
  • Preserves the shared dirty/map-work guard before navigating to manage a visit.

Translated from public/legacy progress UI

  • Uses the public viewer progress modal as a visual reference only, translating the hierarchy and affordances into Vue-native markup and Trip Editor CSS.
  • Adds a percent badge, stronger progress bar treatment, segmented filter buttons, visited/not-visited status indicators, region visited/total counts, per-region progress bars, and compact visit-count pills.

Behavior preserved

  • Filter options still work for all, visited, and not visited places.
  • Close button still works.
  • Manage visit links still use /User/Visit/Edit/{visitId} and guarded navigation still appends the current editor returnUrl.
  • No backend/API/DTO changes were added; the current editor state was enough.
  • Desktop and narrow modal/page overflow checks are covered in focused Playwright.

Validation run

  • npm run build passed; Vite reported the existing large chunk warning.
  • Initial focused Playwright attempt failed because http://localhost:5012 was not running.
  • Second focused Playwright attempt reached the editor but timed out during first login navigation while the app was warming up.
  • After starting ASP.NET on http://localhost:5012 and Vite on http://localhost:5173, rerun passed: npx playwright test --config=playwright.config.ts tests/e2e/trip-editor/tripEditorVisitProgress.spec.ts -> 10 passed.
  • npx playwright test --config=playwright.config.ts tests/e2e/trip-editor/tripEditorVisualPolish.spec.ts -> 4 passed.
  • npx playwright test --config=playwright.config.ts --list -> 118 tests listed.
  • dotnet build passed.
  • dotnet test passed: 1548 passed.
  • dotnet run --project tools/Wayfarer.LocCheck -- --warn 400 --fail 600 passed with existing over-400 LOC warnings only; no touched file crossed the warning threshold.
  • git diff --check origin/main...HEAD passed.
  • git ls-files -- .local playwright-report test-results screenshots traces wwwroot/vite/trip-editor wwwroot/dist returned no tracked artifacts.

Manual-validation notes/screenshots

  • Existing visual-polish Playwright screenshot evidence was generated by tripEditorVisualPolish.spec.ts for desktop-wide, laptop, tablet, and phone-smoke visit-progress states under the local Playwright output directory. No screenshots or Playwright artifacts are committed.

@stef-k stef-k merged commit 522d261 into main May 19, 2026
1 check passed
@stef-k stef-k deleted the fix/trip-editor-visit-progress-polish-309 branch May 19, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Polish Trip Editor visit progress modal parity

1 participant