Polish Trip Editor visit progress modal#311
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #309.
Design changes summary
Visit progress and historymodal with a stronger overall progress summary, percent badge, intentional progress bars, segmented filter controls, status affordances, compact visit-count pills, per-region progress counts, and denser visit detail rows.visitProgress.cssfile.Preserved from the Vue editor
Read-only visitscontext, current filtering state, and existing editor DTO/state model.Manage visitaction.Translated from public/legacy progress UI
Behavior preserved
Manage visitlinks still use/User/Visit/Edit/{visitId}and guarded navigation still appends the current editorreturnUrl.Validation run
npm run buildpassed; Vite reported the existing large chunk warning.http://localhost:5012was not running.http://localhost:5012and Vite onhttp://localhost:5173, rerun passed:npx playwright test --config=playwright.config.ts tests/e2e/trip-editor/tripEditorVisitProgress.spec.ts-> 10 passed.npx playwright test --config=playwright.config.ts tests/e2e/trip-editor/tripEditorVisualPolish.spec.ts-> 4 passed.npx playwright test --config=playwright.config.ts --list-> 118 tests listed.dotnet buildpassed.dotnet testpassed: 1548 passed.dotnet run --project tools/Wayfarer.LocCheck -- --warn 400 --fail 600passed with existing over-400 LOC warnings only; no touched file crossed the warning threshold.git diff --check origin/main...HEADpassed.git ls-files -- .local playwright-report test-results screenshots traces wwwroot/vite/trip-editor wwwroot/distreturned no tracked artifacts.Manual-validation notes/screenshots
tripEditorVisualPolish.spec.tsfor desktop-wide, laptop, tablet, and phone-smoke visit-progress states under the local Playwright output directory. No screenshots or Playwright artifacts are committed.