Conversation
|
Hi @adrianlut, That's interesting! I think there are rare cases where it's hard or impossible to trace the column names throughout pipelines, especially when certain sklearn feature selection transformers are used. That's why I used The change itself looks good, but I would expect it to break some existing tests. Would it be possible to merge the latest changes on the master branch into your branches or rebase them onto the newest master version so that the CI works again? I think we might see some tests failing then, would it be possible to fix them if there are any? |
23fe9c6 to
9964c2a
Compare
|
I have now changed this PR to the master and removed all changes to concatenations because they caused several problems. Since one of the fixes was already done in the rework, this PR is now very small. |
Edit: removed changes are strikethrough
Bug description
The inspections I implemented need the correct column names to work correctly. However, mlinspect replaces the column names with "array" in some cases, making it impossible to detect which input and output columns belong to each other inside of the inspection.
This bug occurs in projections to single columns (Series in the pandas backend) and in the concatenation operation.
Fix description
Extended theget_series_row_iteratorwith the option to get the column name from the Series, if the Series has a name.get_iterator_for_typecall initer_input_annotation_output_mapConcatenationAdded column paramater toiter_input_annotation_output_nary_opExtendediter_input_annotation_output_nary_opto callget_iterator_for_typewith the column namesSupplied the column names from the sklearn backend toiter_input_annotation_output_nary_opAlternative fix
No ideas.