Repository navigation
Add JsonPatchPathNotFound to the type stubs - #252
Merged
Merged
Conversation
stubtest failed on master because the exception added in #250 was missing from jsonpatch-stubs/__init__.pyi. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PewzpjGk8XUYuEdhG8sXSD
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the exception-stub update.
No open issues 🎉
What changed in this PR
Aligns the type stubs with the JsonPatchPathNotFound exception introduced in #250, addressing the reported stubtest failure.
Changes:
- Declares
JsonPatchPathNotFoundas a subclass ofJsonPatchConflict. - Adds type checks for catching the exception and assigning it to its parent type.
| File | Description |
|---|---|
typetests/usage.py |
Checks the new exception’s type and compatibility with JsonPatchConflict. |
jsonpatch-stubs/__init__.pyi |
Adds the missing exception declaration with matching inheritance. |
Review effort: Balanced
|
coverage: 100.0%. remained the same — claude/zen-cori-24p0jo into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stubtest failed on master because the exception added in #250 was
missing from jsonpatch-stubs/init.pyi.
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01PewzpjGk8XUYuEdhG8sXSD