Repository navigation
Wrap sequence append type errors in JsonPointerException - #109
Merged
stefankoegl merged 1 commit intoNov 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change aligning sequence append errors with indexed assignment.
No open issues 🎉
What changed in this PR
This PR makes sequence append errors consistent with indexed assignment by wrapping append TypeError exceptions in JsonPointerException.
Changes:
- Preserve the existing “Invalid assignment target” message for invalid appends.
- Add regression coverage for invalid values and intermediate children with
create=True, valid appends, andinplace=Falsebehavior.
| File | Description |
|---|---|
tests.py |
Adds typed-sequence append tests covering failures, successful appends, and mutation behavior. |
jsonpointer.py |
Catches append TypeError alongside AttributeError and updates the explanatory comment. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assigning an invalid value to a bytearray element raises JsonPointerException, but appending that same value leaks TypeError:
Catch append's TypeError alongside the existing immutable-sequence error, using the same Invalid assignment target message as indexed assignment. This also covers appends through create=True, including attempts to attach a newly built intermediate dictionary to a typed sequence.
Three regression tests cover invalid values, invalid intermediate children, valid appends, and inplace=False. Eight append subcases fail on unchanged master; the existing-index and valid-append controls pass.
Validation on Python 3.12.14: all 88 tests pass, Flake8 passes, and git diff --check is clean. No API or type stub changes.