Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Feature] Add separate progress bars status item #515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
[Feature] Add separate progress bars status item #515
Changes from all commits
0e0eaa7c885009File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also review the code path that clears blink and motion state for this new item? Since this renderer now depends on
blink,wiggle, andtilt, I'm wondering whether the separate bars icon could remain on its last animated frame if blinking stops without an immediate redraw.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
applySeparateBarsIconis wired only inupdateIcons, but animation/blink render paths (updateAnimationFrame,updateAnimationState, andtickBlinkinStatusItemController+Animation.swift) still call onlyapplyIcon. As a result, when loading animation or blink effects are active, the separate bars item does not advance frames and can also stay blank on startup until another settings/store update triggersupdateIconsafterupdateVisibilitycreates the item.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we double-check the startup path for this item when the setting is already enabled?
updateIcons()appears to run beforeupdateVisibility()ininit, andapplySeparateBarsIcon()returns early until the item exists, so I'm wondering whether this status item could be visible but initially blank until a later refresh occurs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we verify how interactions are wired for this new status item? I'm not seeing a
menuor action assigned toseparateBarsStatusItem, so I'm wondering whether it may appear in the menu bar but not respond when clicked.