Improve CI caching, fix lint config, harden Linux supply chain#573
Open
sgrobert wants to merge 1 commit intosteipete:mainfrom
Open
Improve CI caching, fix lint config, harden Linux supply chain#573sgrobert wants to merge 1 commit intosteipete:mainfrom
sgrobert wants to merge 1 commit intosteipete:mainfrom
Conversation
CI caching: - Cache SwiftPM dependencies (.build/artifacts, repositories, workspace-state.json) keyed on Package.resolved hash - Cache lint tools (.build/lint-tools) keyed on pinned versions - Saves ~40-60% CI time on cache hit by skipping swift-syntax resolution and lint tool downloads macOS CI: - Enable parallel testing (was --no-parallel without explanation) Supply chain hardening: - Add SHA256 verification for Linux lint tool binaries (x64 + arm64) for both SwiftFormat 0.59.1 and SwiftLint 0.63.2 - Previously only macOS binaries were verified Lint config cleanup: - Fix header: "Peekaboo" → "CodexBar" in both .swiftlint.yml and .swiftformat - Remove dead Peekaboo path exclusions that don't exist in this repo (Core/PeekabooCore/..., Apps/CLI/.build, Pods, Carthage, fastlane) package.json: - Replace hardcoded /Users/steipete/Projects/codexbar path in start:release with portable $(pwd) so it works for all contributors
Collaborator
|
CI is already fast and stable, so I don’t think we need the caching/optimization changes right now. The Linux checksum verification looks genuinely valuable as hardening, though. Could you split that into a separate PR so we can land the security improvement without taking on extra CI complexity at the same time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-parallel)/Users/steipete/Projects/codexbarinstart:releasewith$(pwd)so it works for contributorsChanges
.github/workflows/ci.ymlactions/cache@v4for SPM deps + lint tools on both macOS and Linux jobs; remove--no-parallelfrom macOS test stepScripts/install_lint_tools.shSWIFTFORMAT_SHA256_LINUX_X64,SWIFTFORMAT_SHA256_LINUX_ARM64,SWIFTLINT_SHA256_LINUX_X64,SWIFTLINT_SHA256_LINUX_ARM64constants; enforce verification on Linux.swiftlint.ymlCore/PeekabooCore/...,Apps/CLI/.build,Pods,Carthage,fastlane).swiftformatCore/PeekabooCore/...excludepackage.jsonstart:releaseuses$(pwd)instead of hardcoded user pathTest plan
pnpm start:releaseworks from any clone directory🤖 Generated with Claude Code