feat(codex): Add reset time display for Codex code review limit#581
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b047704911
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let patterns = [ | ||
| #"Code\s*review[^0-9%]*([0-9]{1,3})%\s*remaining"#, | ||
| #"Core\s*review[^0-9%]*([0-9]{1,3})%\s*remaining"#, | ||
| ] |
There was a problem hiding this comment.
parseCodeReviewRemainingPercent used to accept both Code review and Core review, but this commit drops the Core review regex. If the dashboard text still emits that variant (which the previous fallback indicates was seen in practice), codeReviewRemainingPercent becomes nil, and downstream UI/CLI paths that gate on this field stop showing the Code review metric/reset entirely.
Useful? React with 👍 / 👎.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Q1CHENL
force-pushed
the
qichen/codex-code-review-reset-time
branch
from
b047704 to
952bd58
Compare
|
Is this Core review just a typo? |
|
|
||
| private static func isCodeReviewLimitLine(_ line: String) -> Bool { | ||
| let lower = line.lowercased() | ||
| guard lower.contains("code review") else { return false } |
There was a problem hiding this comment.
Should this matcher handle the same label variants as parseCodeReviewRemainingPercent()? I’m wondering what happens if the dashboard text comes through as Core review here.
There was a problem hiding this comment.
ok cool i patched a fix for that since core review is intentional, not a typo
|
Thanks @Q1CHENL ! |
2 participants
No description provided.