feat: Auto-select provider based on active AI app#582
Open
gamithasam wants to merge 8 commits intosteipete:mainfrom
Open
feat: Auto-select provider based on active AI app#582gamithasam wants to merge 8 commits intosteipete:mainfrom
gamithasam wants to merge 8 commits intosteipete:mainfrom
Conversation
Co-Authored-By: MiniMax M2.5 <noreply@anthropic.com>
When an AI app became active, the menu bar icon updated but the underlying provider wasn't set as selected, so clicking the menu would show the previously selected provider instead. Co-Authored-By: MiniMax M2.7 <noreply@anthropic.com>
…ithasam/CodexBar into feature/auto-select-provider
gamithasam
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 361f481099
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…Icon When the active-app branch is taken on app launch (no didActivateApplication notification received first), the icon updated to the active provider but selectedMenuProvider remained stale, causing the menu to resolve from the wrong provider until the next activation event. Co-Authored-By: MiniMax M2.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
What changed:
ActiveAppDetectorbundle-id mapping for desktop apps (Codex/Claude/Cursor/OpenCode/etc), including Electron Ollama (com.electron.ollama).menuBarShowsActiveProvidertoggle (Display preferences)lastActiveProviderpersistence as a fallback when no relevant AI app is activeStatusItemControllerto observeNSWorkspace.didActivateApplicationNotificationand:selectedMenuProviderin sync when auto-select triggers (so the menu matches the icon)ActiveAppDetectorTestsfor exact/prefix bundle-id mapping + unknown IDsSettingsStoreActiveProviderTestsfor defaults + persistence + invalid raw handlingPreferencesPaneSmokeTeststo include the new toggleTests / checks run:
swift test --filter ActiveAppDetectorTestsswift test --filter SettingsStoreActiveProviderTestsswift test --filter PreferencesPaneSmokeTestscorepack pnpm check./Scripts/compile_and_run.shNotes:
NSWorkspace.frontmostApplication, so the unit tests focus on deterministic mapping + settings persistence; the notification-driven path is covered via integration behavior in-app.