Skip to content

ci: preserve hidden Pages files#23

Merged
steipete merged 1 commit into
mainfrom
fix/pages-nojekyll-artifact
Jul 1, 2026
Merged

ci: preserve hidden Pages files#23
steipete merged 1 commit into
mainfrom
fix/pages-nojekyll-artifact

Conversation

@steipete

@steipete steipete commented Jul 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • preserve the generated .nojekyll file in the GitHub Pages artifact
  • opt into hidden-file packaging required by actions/upload-pages-artifact@v5

Root cause

The v5 action defaults include-hidden-files to false. Sag's docs builder generates dist/docs-site/.nojekyll, so the recent action upgrade silently excluded that file.

Proof

  • pnpm check
  • pnpm build
  • pnpm docs:build
  • actionlint .github/workflows/*.yml
  • local artifact emulation: default v5 exclusion omits .nojekyll; explicit opt-in includes it
  • autoreview: clean, no accepted/actionable findings

Risk: low; one documented action input, limited to Pages artifact packaging.

@steipete
steipete merged commit 01b4313 into main Jul 1, 2026
2 checks passed
@steipete

steipete commented Jul 1, 2026

Copy link
Copy Markdown
Owner Author

Landed as 01b43135f786640e8d0e13dac6e80f62a4c9804c.

Proof:

Live runtime proof: not applicable to this workflow-only packaging fix; the real Pages artifact and deployment are the affected boundary. No caveats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant