Repository navigation
Port mapper on port 0: retry on a random port - #12
Merged
Merged
Conversation
Windows hands out free ports sequentially and can block 200 consecutive ports for one protocol, so retries with any free port stayed inside the block. Measured in hart-sim on six Windows runners.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PortMapper(port=0)needs the same number on TCP and UDP. Windows hands out free ports sequentially and can block 200 consecutive ports for one protocol, so five retries with any free port stayed inside the block. From the second try on, it now picks a random port in the dynamic range, with up to ten tries. A fixed port still fails at once.