Modernise packaging (PEP-621)#1
Open
AlecThomson wants to merge 3 commits into
Open
Conversation
Fixes several errors that arise from changing to cli, adds numpy version condition.
Owner
stella-ocker
left a comment
stella-ocker
left a comment
There was a problem hiding this comment.
Suggest changing NE2001.py back to NE2001p.py and NE2025.py to NE2025p.py, to avoid confusion with files of same name that are under src/mwprop/nemod.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
I hope this is useful.
This PR effectively just implments PEP-621 and puts all metadata into
pyproject.toml. I tried to avoid touching other parts of the codebase, but some script renames were required.Summary of basic changes is:
.pyfrom CLI entry pointspyproject.tomlpyproject.tomlsetup.cfguv.lockforuvbased installs..gitignore