Skip to content

fix: preserve local action directory selection - #255

Merged
jan-kubica merged 2 commits into
mainfrom
fix/checkout-root-actions-20261028
Oct 28, 2026
Merged

jan-kubica merged 2 commits into
mainfrom
fix/checkout-root-actions-20261028

Conversation

@jan-kubica

@jan-kubica jan-kubica commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Reviewed local action consumers were rejected when the action lived at the checkout destination itself or its exact directory was selected by a directory-only sparse pattern.

Share inclusive containment with the default scanner and recognize directory-only equality for local action consumers. Version-file selectors still cannot treat a checkout directory or directory-only sparse pattern as a file.

Follow-up to #249. Focused checkout proof tests: 11 passed, 88 assertions.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 6 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 249e608 and ef7124e.

Files selected for processing: 5
  • .changeset/checkout-root-actions.md
  • packages/oxlint-config/src/toolchain-checkout-sources.test.ts
  • packages/oxlint-config/src/toolchain-checkout-sources.ts
  • packages/oxlint-config/src/toolchain-checkout-syntax.ts
  • packages/oxlint-config/src/toolchain-runtime.ts
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T08:12:14.791267Z 62efbec New commits
🔒 Security Review ✅ Completed 2026-10-28T08:08:29.757283Z 2dac8d7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jan-kubica
jan-kubica force-pushed the fix/reviewed-checkout-sources-20261028 branch from 52bee4d to 684c84d Compare October 28, 2026 08:10
@jan-kubica
jan-kubica force-pushed the fix/checkout-root-actions-20261028 branch from 2dac8d7 to 62efbec Compare October 28, 2026 08:10
@jan-kubica jan-kubica changed the title fix: accept local actions at their checkout root fix: preserve local action directory selection Oct 28, 2026
@jan-kubica
jan-kubica changed the base branch from fix/reviewed-checkout-sources-20261028 to main October 28, 2026 08:25
@jan-kubica
jan-kubica force-pushed the fix/checkout-root-actions-20261028 branch from 81924b3 to ef7124e Compare October 28, 2026 08:27
@jan-kubica
jan-kubica added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit 755986c Oct 28, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant