Repository navigation
fix: inventory conditional workspace lint generators - #256
Conversation
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Recognise conditional Bun scripts packages/oxlint-config/src/toolchain-lint-command.ts, packages/oxlint-config/src/toolchain-lint-command.test.ts, packages/oxlint-config/README.md, .changeset/conditional-lint-generator-inventory.md |
The inventory recognises a quoted environment-variable guard followed by one literal bun run script. Tests cover accepted and rejected forms. The README describes the constraints, and the changeset marks a patch release. |
Validate workspace inventory packages/oxlint-config/src/toolchain-node-projects.test.ts |
Workspace tests cover generator preparation from different working directories, orphan diagnostics in both workspaces, and cyclic script delegation. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Merge Risk: 
01905
-
No merge-blocking risk was identified for conditional generator inventory.
Pre-merge checks: 
-
Check name Status Explanation Title check The title names the main change: lint inventory now handles conditional Bun generators in workspace scripts. It follows the conventional commit style and is specific. It is 52 characters and 6 words, … Description check The description states the problem (lint inventory rejects a workspace script that changes to the repository root, conditionally runs a generator, then lints). It describes the fix: recognising the bo… Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title names the main change: lint inventory now handles conditional Bun generators in workspace scripts. It follows the conventional commit style and is specific. It is 52 characters and 6 words, which fits the concise single-sentence requirement.
Full details: Description check
-
Explanation
The description states the problem (lint inventory rejects a workspace script that changes to the repository root, conditionally runs a generator, then lints). It describes the fix: recognising the bounded conditional Bun preparation form, inventorying the generator in its real workspace, and adding lexer regressions and fixture coverage. This matches the changeset.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 3 files. (2 skipped: 2 unsupported.)
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
43a226f to
0296aec
Compare
0296aec to
0190538
Compare
Lint inventory rejected a workspace script that changes to the repository root, conditionally runs its generator, and then lints the workspace. Flattening the shell group discarded the successful directory context and tried to resolve the generator in the wrong package.
Recognize the bounded
([ -n "$VARIABLE" ] || bun run <script>)preparation form. Inventory the possible generator branch in its actual workspace and retain its nested lint scopes; do not execute the condition or generator. Command substitutions, directory-changing group bodies, extra arguments and ambiguous outer flow remain rejected. Add lexer regressions and extend the real workspace inventory fixture to prove both the generator and final lint orphans remain visible.