-
Notifications
You must be signed in to change notification settings - Fork 51
feat(token-prices): migrate getTokenPrices to v2 indexer endpoint #2870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aristidesstaffieri
wants to merge
12
commits into
master
Choose a base branch
from
feat/token-prices-v2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
db91844
feat(token-prices): migrate getTokenPrices to v2 indexer endpoint
aristidesstaffieri 2abe2bb
Potential fix for pull request finding
aristidesstaffieri 3cd273f
fix(token-prices): key the price cache by network
aristidesstaffieri e820c36
refactor(token-prices): type getTokenPrices network param as string
aristidesstaffieri f1723ea
fix(token-prices): skip request when all tokens are filtered out
aristidesstaffieri 5cb7d2e
fix(token-prices): derive supported price network from passphrase
aristidesstaffieri 226e0c8
fix(token-prices): key price cache by passphrase, not network
aristidesstaffieri 2cc3040
feat(token-prices): gate v1/v2 endpoint behind Amplitude flag
aristidesstaffieri cbe24c1
test(token-prices): pass useV2 arg in getTokenPrices call assertions
aristidesstaffieri 41f0811
refactor(token-prices): extract passphrase→price-network map to share…
aristidesstaffieri c83f229
Merge branch 'master' into feat/token-prices-v2
aristidesstaffieri 6c70dbd
test(token-prices): fix stubSendTokenPrices glob to match v2 query URL
aristidesstaffieri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.