Proposal: Rename extendFootprintTtl.extendTo to minimumTtl for clarity#743
Open
Shaptic wants to merge 1 commit into
Open
Proposal: Rename extendFootprintTtl.extendTo to minimumTtl for clarity#743Shaptic wants to merge 1 commit into
extendFootprintTtl.extendTo to minimumTtl for clarity#743Shaptic wants to merge 1 commit into
Conversation
|
Size Change: +229 B (0%) Total Size: 3.21 MB
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a lengthy discussion on Discord about how the naming of
extendToseems to imply an absolute ledger sequence as the parameter (i.e. extend the lifetime to ledger N). In actuality, this sets the entries' time to live to at least N more ledgers (i.e. extend, but more accurately set the TTL to ledger N).This PR proposes a breaking change to make it
minimumTtlto clarify this.