Skip to content

Support signed payload revoke signer sponsorship#968

Closed
chrisx9z wants to merge 1 commit into
stellar:masterfrom
chrisx9z:fix/revoke-sponsorship-signed-payload
Closed

Support signed payload revoke signer sponsorship#968
chrisx9z wants to merge 1 commit into
stellar:masterfrom
chrisx9z:fix/revoke-sponsorship-signed-payload

Conversation

@chrisx9z

Copy link
Copy Markdown

Summary

  • Adds signerKeyTypeEd25519SignedPayload parsing in convertXDRSignerKeyToObject.
  • Allows Operation.revokeSignerSponsorship to build revoke-signer sponsorship ops for P-address signers.
  • Adds a round-trip test covering build, XDR decode, and Operation.fromXDRObject output.

Fixes #966.

Verification

  • corepack yarn install --ignore-scripts
  • corepack yarn mocha test/unit/operations/classic_ops_test.js --grep "signed payload signer|revokeSignerSponsorship" --require @babel/register --require ./test/test-helper.js
  • corepack yarn eslint -c ./config/.eslintrc.js src/operation.js src/operations/revoke_sponsorship.js
  • node --check src/operation.js
  • node --check src/operations/revoke_sponsorship.js
  • node --check test/unit/operations/classic_ops_test.js
  • git diff --check

Note

  • Running ESLint over the full test/unit/operations/classic_ops_test.js file reports existing style violations unrelated to this change, so source files were linted directly and the changed test path was verified with the focused mocha run and syntax check.

Copilot AI review requested due to automatic review settings May 27, 2026 05:16
Comment: Adds CAP-40 signed payload signer support to revoke signer sponsorship parsing and building.
@Ryang-21

Copy link
Copy Markdown
Contributor

Appreciate the contribution, but will be closing as the issue has been solved. See the issue for documentation

@Ryang-21 Ryang-21 closed this Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RevokeSponsorshipSigner parser/builder missing ed25519SignedPayload (CAP-40) arm

2 participants