Skip to content

wip - refactor nested container layout #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jeesunikim wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

wip - refactor nested container layout #2123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/(sidebar)/transaction/build/components/ClassicOperation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ export const ClassicOperation = ({
{txnOperations.map((op, idx) => (
<Box
key={`op-${idx}`}
gap="lg"
gap="sm"
addlClassName="PageBody__content"
data-testid={`build-transaction-operation-${idx}`}
>
Expand Down
2 changes: 1 addition & 1 deletion src/app/(sidebar)/transaction/dashboard/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@
flex-direction: column;

.Card {
--Card-padding: #{pxToRem(14px)};
--Card-padding: #{pxToRem(16px)};
}
}

Expand Down
134 changes: 68 additions & 66 deletions src/components/ValidationResponseCard/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,75 +22,77 @@ export const ValidationResponseCard = ({
footerRightEl,
}: ValidationResponseCard) => {
return (
<Card>
<Box
gap="lg"
addlClassName="ValidationResponseCard"
data-variant={variant}
>
<>
<Alert variant={variant} placement="inline" title={title}>
{subtitle ?? null}
</Alert>
<div className="ValidationResponseCard">
<Card>
<Box
gap="lg"
// addlClassName="ValidationResponseCard"
data-variant={variant}
>
<>
<Alert variant={variant} placement="inline" title={title}>
{subtitle ?? null}
</Alert>

<Card variant="secondary" noPadding>
<div className="ValidationResponseCard__content">{response}</div>
</Card>
<Card variant="secondary" noPadding>
<div className="ValidationResponseCard__content">{response}</div>
</Card>

{footerLeftEl || footerRightEl || note ? (
<Box gap="lg">
<>
{note ? (
<Text
as="div"
size="xs"
weight="regular"
addlClassName="ValidationResponseCard__note"
>
{note}
</Text>
) : null}
{footerLeftEl || footerRightEl || note ? (
<Box gap="lg">
<>
{note ? (
<Text
as="div"
size="xs"
weight="regular"
addlClassName="ValidationResponseCard__note"
>
{note}
</Text>
) : null}

{footerLeftEl || footerRightEl ? (
<Box
gap="sm"
direction="row"
align="center"
justify="space-between"
addlClassName="ValidationResponseCard__footer"
wrap="wrap"
>
<>
{footerLeftEl ? (
<Box
gap="sm"
direction="row"
addlClassName="ValidationResponseCard__footer--leftEl"
wrap="wrap"
>
<>{footerLeftEl}</>
</Box>
) : null}
{footerLeftEl || footerRightEl ? (
<Box
gap="sm"
direction="row"
align="center"
justify="space-between"
addlClassName="ValidationResponseCard__footer"
wrap="wrap"
>
<>
{footerLeftEl ? (
<Box
gap="sm"
direction="row"
addlClassName="ValidationResponseCard__footer--leftEl"
wrap="wrap"
>
<>{footerLeftEl}</>
</Box>
) : null}

{footerRightEl ? (
<Box
gap="sm"
direction="row"
justify="right"
addlClassName="ValidationResponseCard__footer--rightEl"
wrap="wrap"
>
<>{footerRightEl}</>
</Box>
) : null}
</>
</Box>
) : null}
</>
</Box>
) : null}
</>
</Box>
</Card>
{footerRightEl ? (
<Box
gap="sm"
direction="row"
justify="right"
addlClassName="ValidationResponseCard__footer--rightEl"
wrap="wrap"
>
<>{footerRightEl}</>
</Box>
) : null}
</>
</Box>
) : null}
</>
</Box>
) : null}
</>
</Box>
</Card>
</div>
);
};
4 changes: 4 additions & 0 deletions src/components/ValidationResponseCard/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@
--ValidationResponseCard-title-color: var(--sds-clr-red-11);
}

.Card {
--Card-padding: #{pxToRem(16px)};
}

&__title {
color: var(--ValidationResponseCard-title-color);
}
Expand Down
4 changes: 0 additions & 4 deletions src/styles/globals.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@
min-height: auto !important;
display: block !important;

.Card {
--Card-padding: #{pxToRem(16px)};
}

@media screen and (max-width: 1040px) {
position: relative;
z-index: 10;
Expand Down
Loading