Add `@tanstack/eslint-plugin-query` and update `@typescript-eslint/eslint-plugin` by jeesunikim · Pull Request #2125 · stellar/laboratory

jeesunikim · 2026-06-24T18:26:38Z

No description provided.

…eslint Add @tanstack/eslint-plugin-query as a devDependency. It requires @typescript-eslint/utils ^8.58.1, which would otherwise pull a second @typescript-eslint tree (8.62) alongside the existing 8.43 used by eslint-config-next. Align the family on a single 8.62.0 version by bumping @typescript-eslint/eslint-plugin and adding a matching parser, so the lockfile resolves to one tree instead of two. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Enable plugin:@tanstack/query/recommended in the ESLint config and fix the 19 exhaustive-deps violations it surfaces. Each affected hook read values in its queryFn (most commonly headers, plus url/passphrase/asset/count inputs) that were absent from its queryKey, so distinct inputs could collide on one cache entry and return stale data. Add the missing values to every queryKey. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Fix the "arrowParens:" key (stray colon meant Prettier silently ignored it) and rename the deprecated jsxBracketSameLine to bracketSameLine. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

socket-security · 2026-06-24T18:29:38Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@typescript-eslint/parser@8.62.0
	@tanstack/eslint-plugin-query@5.101.1
	@typescript-eslint/eslint-plugin@8.62.0

View full report

socket-security · 2026-06-24T18:29:40Z

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert (click "▶" to expand/collapse)
Warn		Obfuscated code: npm `@typescript-eslint/eslint-plugin` is 90.0% likely obfuscated Confidence: 0.90 Location: Package overview From: package.json → `npm/@typescript-eslint/eslint-plugin@8.62.0` ℹ Read more on: This package \| This alert \| What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `support@socket.dev`. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/@typescript-eslint/eslint-plugin@8.62.0`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

Copilot

Pull request overview

This PR updates the linting toolchain (adds TanStack Query ESLint rules and bumps @typescript-eslint/*) and adjusts React Query queryKeys across the codebase so cached results correctly vary by inputs like headers, URLs, and other request parameters.

Changes:

Add @tanstack/eslint-plugin-query and enable plugin:@tanstack/query/recommended in ESLint config.
Upgrade @typescript-eslint/eslint-plugin and add @typescript-eslint/parser.
Update multiple React Query hooks’ queryKey definitions to include additional dependencies (notably headers), plus fix Prettier config keys.

Reviewed changes

Copilot reviewed 22 out of 23 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/query/useWasmGitHubAttestation.ts	Includes `headers` in `queryKey` to prevent cache collisions across header changes.
src/query/useWasmBinaryFromRpc.ts	Includes `headers` in `queryKey` for correct caching of RPC wasm binary fetches.
src/query/useRpcHealthCheckUntilReady.ts	Includes `headers` in `queryKey` so health check results vary by request headers.
src/query/useLatestTxn.ts	Adds `headers` to `queryKey` so latest-tx queries are keyed by network/header context.
src/query/useLatestLedger.ts	Keys latest-ledger query by `rpcUrl` + `headers` instead of a global key.
src/query/useHorizonHealthCheckUntilReady.ts	Includes `headers` in `queryKey` for Horizon health polling correctness.
src/query/useGetRpcTxs.ts	Keys RPC tx list by `rpcUrl`, `startLedger`, and `headers`.
src/query/useGetRpcTxDetails.ts	Keys RPC tx detail query by `rpcUrl`, `tx`, and `headers`.
src/query/useGetContractDataFromRpcById.ts	Expands `queryKey` inputs to better reflect parameters that affect contract data lookup.
src/query/useFriendBot.ts	Expands `queryKey` to include network context and headers for Friendbot funding requests.
src/query/useFetchRpcTxDetails.ts	Includes `headers` in `queryKey` for JSON-RPC fetch correctness.
src/query/useEndpoint.ts	Expands `queryKey` to include `requestUrl` and `headers` so endpoint responses aren’t cross-cached.
src/query/useCheckTxSignatures.ts	Keys signature check by XDR/network inputs plus headers.
src/query/useBuildVerification.ts	Includes `headers` in `queryKey` for build verification fetching.
src/query/useBuildRpcTransaction.ts	Expands `queryKey` inputs (but currently misses `rpcUrl`, causing a cache bug).
src/query/useAddTrustline.ts	Expands `queryKey` inputs to include asset/network/header context.
src/query/useAccountSequenceNumber.ts	Keys by account + `horizonUrl` + `headers` to avoid cross-network cache reuse.
src/query/useAccountInfo.ts	Keys by account + `horizonUrl` + `headers`.
src/query/external/useSEContractStorage.ts	Includes `totalEntriesCount` in `queryKey` to keep cache aligned with expected fetch behavior.
package.json	Adds TanStack Query ESLint plugin; upgrades `@typescript-eslint/*` deps.
.eslintrc.json	Enables `plugin:@tanstack/query/recommended`.
.prettierrc.json	Fixes Prettier option keys (`arrowParens`, `bracketSameLine`).
pnpm-lock.yaml	Lockfile updates for the added/updated lint dependencies.

Files not reviewed (1)

pnpm-lock.yaml: Generated file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6c773ffcbd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

stellar-jenkins-ci · 2026-06-24T18:31:41Z

Preview is available here:
http://laboratory-pr2125.previews.kube001.services.stellar-ops.com/

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

stellar-jenkins-ci · 2026-06-25T22:56:22Z

Preview is available here:
http://laboratory-pr2125.previews.kube001.services.stellar-ops.com/

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e730383490

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

stellar-jenkins-ci · 2026-06-26T20:38:05Z

Preview is available here:
http://laboratory-pr2125.previews.kube001.services.stellar-ops.com/

stellar-jenkins-ci · 2026-06-26T20:38:42Z

Preview is available here:
http://laboratory-pr2125.previews.kube001.services.stellar-ops.com/

jeesunikim · 2026-06-26T20:41:32Z


-  const txsQuery = useGetRpcTxs({
+  const {
+    refetch: refetchTxs,


the object returned from the query hook is not referentially stable. the official doc recommends to destructure the return value of the query hook and pass them into dep array instead.

stellar-jenkins-ci · 2026-06-26T21:11:05Z

Preview is available here:
http://laboratory-pr2125.previews.kube001.services.stellar-ops.com/

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

stellar-jenkins-ci · 2026-06-26T21:24:41Z

Preview is available here:
http://laboratory-pr2125.previews.kube001.services.stellar-ops.com/

quietbits · 2026-06-29T14:03:57Z

+  const errorElement = isError ? (
    <Alert variant="error" placement="inline">
-      {txsQuery.error.message}
+      {error?.message}
    </Alert>
  ) : null;


To be safe, should we me checking for the error.message instead of isError?

Suggested change

const errorElement = isError ? (

<Alert variant="error" placement="inline">

{txsQuery.error.message}

{error?.message}

</Alert>

) : null;

const errorElement = error?.message ? (

<Alert variant="error" placement="inline">

{error.message}

</Alert>

) : null;

quietbits · 2026-06-29T14:06:26Z

 }) => {
  const query = useQuery({
-    queryKey: ["accountInfo", publicKey],
+    queryKey: ["accountInfo", publicKey, horizonUrl, headers],


Is headers a string or an object? Just want to make sure the query won't be triggered too often.

jeesunikim and others added 3 commits June 24, 2026 11:02

chore(prettier): fix arrowParens typo and rename deprecated option

6c773ff

Fix the "arrowParens:" key (stray colon meant Prettier silently ignored it) and rename the deprecated jsxBracketSameLine to bracketSameLine. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copilot AI review requested due to automatic review settings June 24, 2026 18:26

github-project-automation Bot added this to DevX Jun 24, 2026

github-project-automation Bot moved this to Backlog (Not Ready) in DevX Jun 24, 2026

jeesunikim linked an issue Jun 24, 2026 that may be closed by this pull request

Add @tanstack/eslint-plugin-query #1924

Open

Copilot started reviewing on behalf of jeesunikim June 24, 2026 18:27 View session

Copilot AI reviewed Jun 24, 2026

View reviewed changes

Comment thread src/query/useBuildRpcTransaction.ts

chatgpt-codex-connector Bot reviewed Jun 24, 2026

View reviewed changes

Comment thread src/query/useBuildRpcTransaction.ts

Comment thread src/query/useLatestTxn.ts

Potential fix for pull request finding

e730383

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

chatgpt-codex-connector Bot reviewed Jun 25, 2026

View reviewed changes

Comment thread .eslintrc.json

jeesunikim added 2 commits June 26, 2026 13:32

remove useQuery result from dependencies

7433dc8

Merge branch 'main' into tanstack/eslint-plugin-query

f0ce7ee

jeesunikim commented Jun 26, 2026

View reviewed changes

throw an error propery from useGetRpcTx

3a7f670

jeesunikim requested a review from quietbits June 26, 2026 21:16

extract getErrorMessage into errorUtils helper

30c12d0

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

quietbits approved these changes Jun 29, 2026

View reviewed changes

Uh oh!

Conversation

jeesunikim commented Jun 24, 2026

Uh oh!

socket-security Bot commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security Bot commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

stellar-jenkins-ci Bot commented Jun 24, 2026

Uh oh!

stellar-jenkins-ci Bot commented Jun 25, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

stellar-jenkins-ci Bot commented Jun 26, 2026

Uh oh!

stellar-jenkins-ci Bot commented Jun 26, 2026

Uh oh!

jeesunikim Jun 26, 2026

Choose a reason for hiding this comment

Uh oh!

stellar-jenkins-ci Bot commented Jun 26, 2026

Uh oh!

stellar-jenkins-ci Bot commented Jun 26, 2026

Uh oh!

quietbits Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

quietbits Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

socket-security Bot commented Jun 24, 2026 •

edited

Loading

socket-security Bot commented Jun 24, 2026 •

edited

Loading