Transaction Dashboard: Call Stack Trace tab tests#2126
Merged
Conversation
quietbits
commented
Jun 26, 2026
quietbits
commented
Contributor
- Refactored code to create helpers to test with unit tests
- Basic e2e tests
|
Preview is available here: |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds automated coverage for the Transaction Dashboard’s Call stack trace tab by extracting UI-specific formatting/truncation logic into standalone helpers with unit tests, and by introducing Playwright e2e tests plus fixtures that exercise key UI states.
Changes:
- Refactors
CallStackTraceto use new helper modules (truncateParams,hasEllipsisAnywhere,toErrorMapData,isAsset,renderAssetString) and addsdata-testidhooks to support e2e testing. - Adds unit tests for the new call-stack-trace helper functions.
- Adds Playwright e2e tests and mocked
getTransactionRPC responses for empty/success/failure/long-params scenarios.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/callStackTrace/truncateParams.test.ts | Adds unit coverage for param truncation behavior. |
| tests/unit/callStackTrace/toErrorMapData.test.ts | Adds unit coverage for converting error values into renderable nodes. |
| tests/unit/callStackTrace/renderAssetString.test.ts | Adds unit coverage for asset string display formatting. |
| tests/unit/callStackTrace/isAsset.test.ts | Adds unit coverage for asset-string detection. |
| tests/unit/callStackTrace/hasEllipsisAnywhere.test.ts | Adds unit coverage for ellipsis detection in nested structures. |
| tests/e2e/txDashCallStackTrace.test.ts | Adds e2e tests validating call stack trace UI behavior (alerts, truncation, chevrons, links). |
| tests/e2e/mock/txCallStackTrace.ts | Adds minimal mocked getTransaction responses for e2e scenarios. |
| src/helpers/callStackTrace/truncateParams.ts | Extracts param truncation logic into a reusable helper. |
| src/helpers/callStackTrace/toErrorMapData.ts | Extracts error-to-renderable-node conversion helper. |
| src/helpers/callStackTrace/renderAssetString.ts | Extracts asset display formatting helper. |
| src/helpers/callStackTrace/isAsset.ts | Extracts asset detection helper. |
| src/helpers/callStackTrace/hasEllipsisAnywhere.ts | Extracts ellipsis detection helper. |
| src/constants/networkLimits.ts | Updates generated network limits constants. |
| src/app/(sidebar)/transaction/dashboard/components/CallStackTrace.tsx | Integrates helpers + adds test ids for e2e selectors. |
| .gitignore | Updates ignored paths and normalizes env entry formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Preview is available here: |
jeesunikim
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.