SPIKE: Protocol 28 (CAP-0084)#2131
Draft
sisuresh wants to merge 2 commits into
Draft
Conversation
Pin the JS XDR stack to the CAP-0084 SPIKE forks so lab can decode and render
the new SC_ADDRESS_TYPE_MUXED_CONTRACT arm on SCAddress:
- package.json: @stellar/stellar-sdk + @stellar/stellar-xdr-json → local CAP-0084
tarballs (local-pkgs/)
- pnpm-workspace.yaml: override @stellar/stellar-base → CAP-0084 fork tarball so
all transitive consumers (sdk lib/, wallets-kit) share the patched codec
- createStore.ts: NEXT_PUBLIC_CUSTOM_{HORIZON_URL,RPC_URL,PASSPHRASE} fallbacks
for the Quickstart-bundled lab
Upstream SPIKE PRs (cross-linked):
- js-stellar-base sisuresh/js-stellar-base#2
- js-stellar-sdk sisuresh/js-stellar-sdk#2
- js-stellar-xdr-json sisuresh/js-stellar-xdr-json#2
The SC_ADDRESS_TYPE_MUXED_CONTRACT arm was leaking into the released `curr` codec of both stellar-base and the sdk's vendored base. Re-pin to freshly built tarballs that gate the arm to the `next` channel only. - stellar-base-cap0084-v2.tgz: stellar/js-stellar-base#980 head — curr codec drops the muxed-contract arm; fromScAddress guarded so the curr-bound Address codec no longer throws. - stellar-sdk-cap0084-v2.tgz: stellar/js-stellar-sdk#1499 head — same gating in the vendored base + browser bundle rebuilt. - stellar-xdr-json unchanged (head did not advance). - Renamed tarballs to -v2 to defeat pnpm's content-addressable file: cache; lockfile regenerated against all three pins.
This was referenced Jun 27, 2026
|
Preview is available here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins the JS XDR stack to the CAP-0084 SPIKE forks so lab can decode and render the new
SC_ADDRESS_TYPE_MUXED_CONTRACTarm onSCAddress. Lab decodes XDR generically via the codec +stellar-xdr-json, so the arm flows in purely through the dep bump.Changes
package.json/pnpm-workspace.yaml: pin@stellar/stellar-sdk+@stellar/stellar-baseto local CAP-0084file:tarballs;@stellar/stellar-xdr-jsonlikewise; lockfile pinned to all three.nextchannel only (was leaking into releasedcurr); cascaded an SDK browser rebuild. Tarballs renamed-v2to defeat pnpm's content-addressable cache.createStore.ts:NEXT_PUBLIC_CUSTOM_{HORIZON_URL,RPC_URL,PASSPHRASE}fallbacks for the Quickstart-bundled lab.Deferred
file:tarballs of the SPIKE forks; will flip to published versions once upstreams release.Upstream (full head SHAs)
@stellar/stellar-base← SPIKE: Protocol 28 (CAP-0084) js-stellar-base#980 (9adecba76f373b2745c22a6512e81f4614092ba5) — gates muxed-contract arm tonext-only.@stellar/stellar-sdk← SPIKE: Protocol 28 (CAP-0084) js-stellar-sdk#1499 (abe08a32b6f12961a5555860ffc1a46e1b8ae3ef) — same gating in vendored base + browser rebuild.@stellar/stellar-xdr-json← SPIKE: Protocol 28 (CAP-0084) js-stellar-xdr-json#58 (48cd6329a79b30113a760fbd0c0b534beda567f7).