Add libunwind-20-dev dependency for core jammy#216
Open
SirTyson wants to merge 1 commit intostellar:masterfrom
Open
Add libunwind-20-dev dependency for core jammy#216SirTyson wants to merge 1 commit intostellar:masterfrom
SirTyson wants to merge 1 commit intostellar:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds the libunwind-20-dev package as an explicit build dependency for stellar-core on Ubuntu Jammy (22.04). This prevents dependency conflicts that occur when libgoogle-perftools-dev automatically pulls in the older libunwind-dev from the main apt mirror, which later conflicts with the newer version from the LLVM repository.
Changes:
- Added
libunwind-20-devto the Build-Depends list in the stellar-core debian control file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Interesting. In PR stellar/stellar-core#5088 we had removed this. |
jacekn
approved these changes
Jan 27, 2026
Contributor
jacekn
left a comment
jacekn
left a comment
There was a problem hiding this comment.
LG! Noting that the package comes from the llvm-20 repo for jammy, it's not in the Ubuntu archives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like we need to explicitly add a dependency for
libunwind-20-devfor the tmalloc dependency for jammy. Otherwise, when we go to installlibgoogle-perftools-dev. it will add the olderlibunwind-devfrom the main apt mirror, which later conflicts when we try to get the newlibunwind-devfrom the LLVM repo.