Fix Error trait impl #450
Merged
Fix Error trait impl #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmkozh
approved these changes
Jul 25, 2025
Contributor
dmkozh
left a comment
dmkozh
left a comment
There was a problem hiding this comment.
Is this a protocol change? That would be fine, we'll need to release another RC of env, so we could pick this up. But we need to understand that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix the trait impls of the Error type that had gaps, missing variant comparisons and missing impls in getting source errors.
Why
The current implementation incorrectly compares errors and is missing some impls on some error variants, such as being able to get the source.
Supersedes:
Merging
Intended to be merged to
mainafter: