fix(deps): pin demucs<4.1 to keep tested 4.0.1 (fixes macOS x64 build) - #257
Merged
Conversation
demucs 4.1.0 (published 2026-07-11) added a dependency on `sphn`, a Rust/CMake native package with no Intel-macOS wheel. The macOS x64 release build resolves deps fresh (not from uv.lock) and picked up 4.1.0, then failed compiling sphn from source (CMake dropped <3.5 compatibility). Linux/Windows only survived because sphn ships wheels there, silently shipping the untested 4.1.0. Pin >=4.0.1,<4.1 so every build path uses the 4.0.1 that the lockfile and the torch/torchaudio pins were written for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
demucs 4.1.0 (2026-07-11) added a native
sphndependency with no Intel-macOS wheel, breaking the x64 macOS release build (CMake <3.5 removed). The release install path resolves fresh (ignores uv.lock), so it grabbed 4.1.0. Linux/Windows survived on sphn wheels but silently shipped the untested 4.1.0.Pin
demucs>=4.0.1,<4.1- the version every prior release shipped and the one the torch pins target. uv.lock unchanged at 4.0.1.