fix(ci): docker-publish never fires on prereleased -- restore published - #266
Merged
Conversation
…ished` Publishing v0.8.0-alpha.7 (a draft prerelease -> published) never triggered Docker Publish: CI/Linux/Windows/macOS releases all still listen for `published` and fired correctly, but docker-publish.yml (changed in #259) only listened for [prereleased, released] -- and `prereleased` did not fire for this publish. Result: ghcr.io/stemdeckapp/stemdeck:0.8.0-alpha.7 was never pushed, while the Unraid CA template already points at that (nonexistent) tag. Fix: trigger on [published, released] -- published is the reliable trigger every other release workflow already relies on; released is kept for promoting an already-published prerelease to Latest via the release-label edit. The :latest condition now also covers a plain non-prerelease `published` (not just `released`), so a first-time stable release still gets :latest. Also add a workflow_dispatch `version` input, so a specific tag can be (re)pushed by hand to recover from a missed trigger without re-touching the release (which would needlessly re-run the OS build workflows).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug found live
Publishing v0.8.0-alpha.7 (draft prerelease -> published) never triggered Docker Publish. CI/Linux/Windows/macOS release workflows all still listen for
publishedand fired correctly on the release event, butdocker-publish.yml(changed in #259) only listened for[prereleased, released]-- andprereleaseddid not fire for this publish. Result:ghcr.io/stemdeckapp/stemdeck:0.8.0-alpha.7was never pushed, while the Unraid CA template (merged in #265) already points at that tag -- so any Unraid install right now hits image-not-found.Confirmed via the GHCR registry API:
HEAD/manifest pull for:0.8.0-alpha.7returned 404 before this fix.Fix
[published, released]instead of[prereleased, released].publishedis the reliable trigger every other release workflow already relies on.:latestnow fires onreleased, OR a plain non-prereleasepublished(so a first publish of a real stable release still gets:latest, not just a promote-from-prerelease edit).workflow_dispatchversioninput, so a specific tag can be pushed by hand to recover from a missed trigger without re-touching the release (which would needlessly re-run the OS build workflows again).Verified
Dispatched this branch's workflow with
version=0.8.0-alpha.7(run 29282509362) to push the tag that alpha.7's publish missed, without re-running the OS builds. Confirmed the tag now exists in GHCR (anonymous manifest pull succeeds).Not merged -- opening for review per the no-auto-merge rule. The immediate breakage (missing tag) is already resolved by the manual dispatch above regardless of when this merges.