feat(settings): export sample rate option + reorganize settings tabs - #270
Merged
Conversation
added 2 commits
July 16, 2026 12:49
Add a configurable export sample rate for mix/region downloads (WAV/FLAC/ MP3), addressing hardware samplers (e.g. Akai MPC) that reject 44.1 kHz. The rate is a runtime setting read live by the mixdown endpoint, applied via ffmpeg -ar; default 44.1 kHz (the stem rate) is a no-op. Reorganize the Settings dialog into General / Network / Export tabs: - General: max track length, compute device, out-of-sync tracks - Network: availability toggle + QR, Port (moved here) - Export: sample rate, MP4 video quality (moved here) Also: - Port field now shows the live serving port, not the stale saved preference (editing still saves the preference for next restart). - In server mode the network toggle renders on + read-only, with an inline note explaining it is governed by server configuration.
Pin the settings dialog to a fixed height and let every pane fill it (flex:1), so switching between General / Network / Export no longer resizes the dialog. The General pane scrolls within the fixed area. Refs #271
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #271
Why
A user reported their Akai MPC rejects exported mixes ("always exports at 1411 kbps"). Exports were locked to the stems' native 44.1 kHz with no way to change it. This adds a configurable export sample rate, and while in the Settings dialog, reorganizes it into clearer tabs.
What
Export sample rate (the core feature)
export_sample_rate(allowlist: 22.05 / 32 / 44.1 / 48 kHz; default 44.1 kHz = the Demucs stem rate, so a no-op unless changed).-ar, so it covers the full mix, region exports, and the mobile client — everything routes through the oneget_mixdowncommand.Settings dialog reorganized: General / Network / Export
Smaller fixes bundled in
Testing
pytest tests/test_stems_api.py tests/test_network_gate.py→ 65 passed (incl. a new test decoding the WAV header to confirm the-arrate takes effect, and settings round-trip / allowlist-rejection tests).ruff check+ruff format --checkclean.