Add an on-demand macOS Rust check on the self-hosted runner - #391
Merged
Conversation
ci.yml (PR-triggered) is 100% ubuntu-latest, so code behind #[cfg(target_os = "macos")] has never had a real compiler pass before merging - that cfg-gated code is stripped before semantic analysis even starts on a non-matching target, not just skipped at test time. macos-release.yml already has a real macOS runner, but only fires on release: published and does the full signed/packaged build. This is deliberately narrow: build/clippy/test only, workflow_dispatch only (not on every PR/push, so the runner's load and cost don't change from today), never touches signing, packaging, or uploads.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bootstrapping commit split out of #390 - GitHub only allows dispatching a
workflow_dispatchworkflow that already exists on the default branch, so this needs to land onmainbefore it can be used to actually verify #390's macOS-specific changes.ci.yml(PR-triggered) is 100%ubuntu-latest, so code behind#[cfg(target_os = "macos")]has never had a real compiler pass before merging - that cfg-gated code is stripped before semantic analysis even starts on a non-matching target, not just skipped at test time.macos-release.ymlalready has a real macOS runner, but only fires onrelease: publishedand does the full signed/packaged build.This is deliberately narrow: build/clippy/test only,
workflow_dispatchonly (not on every PR/push, so the runner's load and cost don't change from today), never touches signing, packaging, or uploads.Test plan
Purely additive CI config, inert until manually triggered. No app code touched.