windows-check.yml: use powershell, not bash - #393
Merged
Conversation
bash on this self-hosted Windows runner mangles the auto-generated temp script's path (backslashes stripped), the same thing windows-release.yml's own steps already worked around by using powershell. Copied macos-check.yml's shell: bash default without adjusting for the platform - caught by this workflow's own first real run (exit 1 on cargo fmt --check, before it even reached the code).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`windows-check.yml`'s first real run failed immediately on `cargo fmt --check` with `bash: ...sh: No such file or directory` - not a real formatting issue, an infrastructure one. `shell: bash` on this self-hosted Windows runner mangles the auto-generated temp script's Windows-style path (backslashes stripped). `windows-release.yml`'s own steps already use `shell: powershell` for exactly this reason; this workflow copied `macos-check.yml`'s bash default without adjusting for the platform.
Test plan
Purely CI config. Will dispatch `windows-check.yml` against `main` after merging to confirm it actually runs clean this time.