Revert SignPath CI until the integration is finished - #400
Merged
Conversation
This reverts commit 7eba634.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SIGNPATH_API_TOKEN and SIGNPATH_ORGANIZATION_ID aren't configured in the repo yet, so a release-triggered run of the sign-exe job added in #394 fails on main today, not just waits on approval. That blocks cutting any release directly from main until SignPath is finished.
This reverts #394 so main goes back to the pre-SignPath, working Windows release path. That's what let v0.11.2 skip the blocker (cut from a branch off the v0.11.1 tag) instead of going through main; with this reverted, main itself is unblocked for normal direct-to-main work and future patch releases.
Re-apply when picking SignPath back up: git revert this commit (or cherry-pick 7eba634 again) once the secrets/variable are set and the SignPath project/policy is approved, then cut v0.12.0.
Test plan