polish: compact DAW summary bar, distinct mute color, We Recommend updates - #412
Merged
Conversation
…dates - Footer overview waveform bar shrunk from 52px to 31px; it and the beat grid overlay already resize off clientHeight so no JS changes needed. - Track/meta summary cards (Key, BPM, LUFS, etc.): vertical padding cut from 14px to 4px and content centered vertically, so cards without a sub-label (BPM, Vocal Presence, ...) don't sit top-anchored next to taller ones that have one. - Mute button now lights up blue when engaged, mirroring the solo button's own lit-up gold treatment -- it previously just faded to opacity 0.35 with no distinct "pressed" color, unlike solo. - We Recommend: added Beltr, and rewrote the flatter one-line descriptions (Analog4Lyfe, Dlima Guitars, Empress Effects, Joao Gaspar, Kris Luthier, Lisbon Guitar Works, Thomann) to be more specific and readable. Also fixed catalog.js's in-app list, which had drifted from README.md (stale "YouTube channel" role, two entries missing a role line entirely).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clientHeightviaResizeObserver, so no JS changes were needed.justify-content: center) so cards without a sub-label line (BPM, Vocal Presence, etc.) don't sit top-anchored next to taller cards that have one (Key, LUFS).opacity: 0.35with no distinct "pressed" color, so it didn't read as an active toggle the way solo did.catalog.js's in-app list, which had drifted fromREADME.md(a stale "YouTube channel" role for More Notes Less Talk, and two entries missing a role line entirely).Test plan
node --check static/js/catalog.jspasses