Skip to content

Clear existing lint warnings - #15

Closed
xy200303 wants to merge 6 commits into
stepfun-ai:mainfrom
xy200303:chore/clear-lint-warnings
Closed

Clear existing lint warnings#15
xy200303 wants to merge 6 commits into
stepfun-ai:mainfrom
xy200303:chore/clear-lint-warnings

Conversation

@xy200303

@xy200303 xy200303 commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace single-argument new Array(...) usage in VAD edit-distance helpers with Array.from(...) initialization.
  • Remove an unused catch binding in the Stepfun stateless backend JSON parser.
  • Avoid aliasing this in the browser AEC capture async iterator.
  • Keep this stacked branch current with the latest Reject malformed numeric CLI options #17 updates.

Verification

  • pnpm exec oxlint extensions/realtime-aec/src/browser-audio-driver.ts packages/realtime/src/backend/stepfun-stateless.ts packages/realtime/src/vad/cli-handlers.ts packages/realtime/src/vad/resolver.ts
  • pnpm exec prettier --check extensions/realtime-aec/src/browser-audio-driver.ts packages/realtime/src/backend/stepfun-stateless.ts packages/realtime/src/vad/cli-handlers.ts packages/realtime/src/vad/resolver.ts packages/utils/src/path.test.ts packages/utils/src/shell.test.ts src/commands/artifacts-command.ts src/commands/option-parsers.ts src/commands/option-parsers.test.ts
  • pnpm exec vitest run packages/realtime/src/vad/resolver.test.ts packages/realtime/src/backend/stepfun-stateless.test.ts packages/utils/src/path.test.ts packages/utils/src/shell.test.ts src/commands/option-parsers.test.ts
  • pnpm exec tsc --noEmit --pretty false
  • pnpm check

Notes

@xy200303
xy200303 force-pushed the chore/clear-lint-warnings branch from 1e479d8 to 93a2224 Compare June 12, 2026 05:35
@ZouR-Ma

ZouR-Ma commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the contribution!

To get this ready to merge:

  • Reference an issue in the description with Closes #<number> (our link-check CI requires it; open one first if needed).
  • Make sure pnpm check passes locally (lint, type-check, dependency/dead-code guards, formatting, and tests — also enforced in CI).

Full conventions:
https://github.com/stepfun-ai/Step-Realtime-CLI/blob/main/CONTRIBUTING.md

@github-actions github-actions Bot added area/cli src/cli, src/commands, src/runtime, src/bootstrap, src/*.ts area/realtime packages/realtime + extensions/realtime-* area/utils packages/utils labels Jun 18, 2026
@xy200303

Copy link
Copy Markdown
Contributor Author

Thanks! I've addressed the feedback on this PR:

This should be ready for review/merge when you have a chance.

@li-xiu-qi

Copy link
Copy Markdown
Contributor

Hi @xy200303, thanks for the cleanup. This PR overlaps with #41 and #68 on the VAD sparse array fix (cli-handlers.ts, resolver.ts) and the unused catch parameter in stepfun-stateless.ts. Those PRs are currently open and cover the same files. Wanted to flag the overlap in case you want to coordinate or consolidate.

@ZouR-Ma

ZouR-Ma commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Thanks for this PR — and for the record, you fixed these lint issues on June 10, a month before the change that eventually landed. However, #10 was merged on July 10 and cleared the warnings in the same four files. We compared file by file: browser-audio-driver.ts and stepfun-stateless.ts match this PR exactly, and the two VAD files differ only in a loop variable's name. Everything unique to this PR already exists on main, which is also why it now shows conflicts.

So we're closing this PR — not because anything is wrong with it, but because the same work has already landed. Two ways to keep contributing here:

  1. If pnpm lint on the latest main still shows leftover warnings elsewhere, a fresh PR from the current main is welcome (as a standalone branch this time, not stacked on another PR). If it's clean, we'll close issue #67 as well.
  2. Your #17 (strict numeric option parsing) is still very much alive — see the review comments there; it can land quickly once slimmed down.

@ZouR-Ma ZouR-Ma closed this Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cli src/cli, src/commands, src/runtime, src/bootstrap, src/*.ts area/realtime packages/realtime + extensions/realtime-* area/utils packages/utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clear existing lint warnings

3 participants