Repository navigation
Refactor: architecture cleanup - #69
Merged
Merged
Conversation
…de, reduce duplication - Move PRIORITY_NAMES constant from Cli::Formatter to Models::Card, fixing upward dependency from model to CLI layer - Extract normalize_timestamp into shared Superthread::TimeUtils module - Delete dead code: Confirmable concern, LinkedCard model, LinkedCardRef#to_s override, workspace_path helper - Replace duplicate apply_date_filters with DateParsable#filter_by_date - Migrate Cards CLI from inline begin/rescue to with_not_found helper - Extract resolve_list_with_context into three focused private methods - Add architecture assessment document
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Models::Cardno longer depends onCli::Formatterfor priority labels;normalize_timestampextracted from CLI layer into sharedSuperthread::TimeUtilsmoduleConfirmableconcern,LinkedCardmodel,LinkedCardRef#to_soverride, andworkspace_pathhelper (-100 lines net)apply_date_filtersin Cards CLI with existingDateParsable#filter_by_dateconcern; migrated 4 inlinebegin/rescueblocks towith_not_foundhelper (matching pages.rb pattern)resolve_list_with_contextinto three focused methods; fixed yard-lint warning onConcernsmodulearchitecture-assessment.mddocuments findings and prioritized recommendationsTest plan
standardrbpasses with no offensesyard-lint lib/passes with no offenses