Repository navigation
fix: paginate cards list and fix search returning 0 results - #75
Merged
Merged
Conversation
Cards list (#73): The views/preview API paginates at 25 items but the CLI only fetched page 1. Added cursor-based pagination that follows all pages via query parameter, matching the pattern already used by search. Both `list` and `assigned` methods now return complete results. Search (#74): The API defaults `grouped` to true when the parameter is omitted. The CLI passed `grouped: nil` which compact_params stripped, so the API returned type-grouped results while the code read from `response[:results]` (only populated when grouped=false). Now ensures grouped=false is always sent when not explicitly set to true. Closes #73, closes #74
Owner
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
listandassignedmethods now return complete results.groupedtotruewhen omitted. The CLI passedgrouped: nilwhichcompact_paramsstripped, so the API returned type-grouped keys while the code read fromresponse[:results](only populated whengrouped=false). Fixed by ensuringgrouped=falseis always sent.Closes #73, closes #74
Test plan