Skip to content

fix: paginate cards list and fix search returning 0 results - #75

Merged
steveclarke merged 1 commit into
masterfrom
fix/pagination-and-search
Mar 24, 2026
Merged

steveclarke merged 1 commit into
masterfrom
fix/pagination-and-search

Conversation

@steveclarke

Copy link
Copy Markdown
Owner

Summary

  • Cards list pagination (cards list silently caps at 25 results, ignores --limit flag #73): The views/preview API paginates at 25 items per page but the CLI only fetched page 1, silently dropping cards. Added cursor-based pagination that follows all pages (cursor passed as query parameter). Both list and assigned methods now return complete results.
  • Search returning 0 results (search query returns 0 results for cards that exist #74): The API defaults grouped to true when omitted. The CLI passed grouped: nil which compact_params stripped, so the API returned type-grouped keys while the code read from response[:results] (only populated when grouped=false). Fixed by ensuring grouped=false is always sent.

Closes #73, closes #74

Test plan

  • 738 existing specs pass
  • 3 new specs for cards list pagination (multi-page, cursor as query param, stop on empty cursor)
  • 1 new spec for search grouped=false default
  • Verified against live API: board 49 returns 31 cards (was 25), search "training" returns 62 results (was 0)

Cards list (#73): The views/preview API paginates at 25 items but the
CLI only fetched page 1. Added cursor-based pagination that follows
all pages via query parameter, matching the pattern already used by
search. Both `list` and `assigned` methods now return complete results.

Search (#74): The API defaults `grouped` to true when the parameter is
omitted. The CLI passed `grouped: nil` which compact_params stripped,
so the API returned type-grouped results while the code read from
`response[:results]` (only populated when grouped=false). Now ensures
grouped=false is always sent when not explicitly set to true.

Closes #73, closes #74
@steveclarke

Copy link
Copy Markdown
Owner Author

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

@steveclarke
steveclarke merged commit 5bf0369 into master Mar 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

search query returns 0 results for cards that exist cards list silently caps at 25 results, ignores --limit flag

1 participant