Repository navigation
fix(ls): resolve the project before listing its scenes (#33) - #37
Merged
Merged
Conversation
`ls scenes` passed its argument straight to the board, so a name the board did not know came back as an empty list. "No scenes found" is a plausible wrong answer: it reads as "this project is empty" rather than "you named a project that does not exist", and it cost a rollback point on a live rig. ResolveProject already accepted either the display title or the slot name; `ls scenes` was the one caller not using it. Now "135 Main Live" works alongside "03.135 Main Live.proj", and an unknown name fails and points at `ls projects`. The empty state names the project it is talking about. Claude-Session: https://claude.ai/code/session_01GgSVDxA51iXZ2nyBaNvGeV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33.
ls scenespassed its argument straight to the board, so an unknown project came back as an empty list rather than an error. "No scenes found" is a plausible wrong answer — it reads as "this project is empty" — and it already cost a rollback point while configuring a live 32R.ResolveProjectwas already there and already accepted either form;ls sceneswas the one caller not going through it.The empty state now names the project it means (
(135 Main Live has no scenes)), so it can't be confused with the not-found case.Tests: two e2e cases — display-title resolution, and unknown-project failing instead of listing nothing. 490 unit, 90 e2e, lint clean.
https://claude.ai/code/session_01GgSVDxA51iXZ2nyBaNvGeV