feat: remove monocart-coverage-reports dependency#70
Merged
Conversation
- Port CDP client directly into src/collector/cdp-client.ts using Node.js 22 native WebSocket global - Remove monocart-coverage-reports from dependencies - Bump engines.node to >=22.0.0 - Disable worker threads on Windows by default to fix STATUS_OBJECT_NAME_NOT_FOUND crash from Rollup native addon - Fix ESLint errors in merge.ts, in-process.ts, sourcemap-loader.ts - Add comprehensive unit tests for cdp-client.ts (34 tests) - Bump version to 1.5.0 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
monocart-coverage-reportsdirectly intosrc/collector/cdp-client.ts, using Node.js 22's built-inWebSocketglobalmonocart-coverage-reportsfromdependenciesand bumpsengines.nodeto>=22.0.0STATUS_OBJECT_NAME_NOT_FOUND(0xC0000034) crash caused by Rollup's native Rust addon failing in worker thread context — falls back to single-threadedrunTaskDirectpath automaticallymerge.ts,in-process.ts,sourcemap-loader.tscdp-client.tsCloses #61
Test plan
npm testpasses (803 tests across 33 suites)STATUS_OBJECT_NAME_NOT_FOUNDcrash aftermergeV8CoverageByUrlNEXTCOV_WORKERS=4override still enables workers on Windows when explicitly set🤖 Generated with Claude Code