Skip to content

Naming convention inconsistent for Julia #37

Description

@chakravala

The naming conventions seem inconsistent with typical Julia conventions and are all over the place.

Perhaps wp should be named weierstrassp for example, although wp may be fine.

The name halfPeriods is not consistent with Julia naming conventions, it should probably be halfperiods without the capitalization, since capitalization in Julia is usually for structs and types, not for function names. Same with ellipticInvariants.

You could also define const ℘ = wp and export it, since the \wp symbol exists for Julia users.

This isn't a huge issue, but the naming conventions could be more consistent with typical Julia naming conventions.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions