feat: remove background from invite embed and modal#987
Closed
gabrielfordevelopment wants to merge 1 commit into
Closed
feat: remove background from invite embed and modal#987gabrielfordevelopment wants to merge 1 commit into
gabrielfordevelopment wants to merge 1 commit into
Conversation
Signed-off-by: Gabriel <60961939+nemethgaborradnoti@users.noreply.github.com>
Contributor
|
I appreciate the attempt given the lack of information. I've added @insertish and @infi to take a look. Hopefully I can add more details to those tickets soon |
Contributor
|
I don't get the appeal personally, looks less clean to me, like the content is bleeding out because you can't tell where the box starts and ends, it's more visually confusing design. |
Contributor
|
This PR is not eligible for merge as it contains many changes which should all be in separate PRs. |
Contributor
Author
Contributor
Contributor
Agreed, discussions for what the issue is referring to should be made in #977. Edit: i read the issue number wrong, fixed it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




closes #977 if I did it correctly. The feature wasn't detailed well, so I had to figure out something. If need further investigation, please let me know
Removed the background color from the Invite message embed to blend with the chat.
Removed the server banner backdrop from the Invite modal for a cleaner appearance.
Cleaned up unused background image references in the Authentication page.
Before
After